t

backend/main.py

@@ -182,14 +182,15 @@ def translate_text(text, source_lang, target_lang):
             return use_fallback_translation(text, source_lang, target_lang)
     
     try:
-        # Only send the raw text to the Helsinki model
-        text_to_translate = text
+        # Ensure only the raw text is sent to the Helsinki model
+        text_to_translate = text 
+        print(f"Translating text (first 50 chars): {text_to_translate[:50]}...") # Log the actual text being sent
         
         # Use a more reliable timeout approach with concurrent.futures
         with concurrent.futures.ThreadPoolExecutor() as executor:
             future = executor.submit(
                 lambda: translator(
-                    text_to_translate,
+                    text_to_translate, # Pass only the raw text
                     max_length=768
                 )[0]["translation_text"]
             )
@@ -198,17 +199,17 @@ def translate_text(text, source_lang, target_lang):
                 # Set a reasonable timeout
                 result = future.result(timeout=10)
                 
-                # Post-process the result for Arabic cultural adaptation
+                # Post-process the result for Arabic cultural adaptation if needed
                 if target_lang == "ar":
                     result = culturally_adapt_arabic(result)
                 
+                print(f"Translation successful (first 50 chars): {result[:50]}...")
                 return result
             except concurrent.futures.TimeoutError:
                 print(f"Model inference timed out after 10 seconds, falling back to online translation")
                 return use_fallback_translation(text, source_lang, target_lang)
             except Exception as e:
                 print(f"Error during model inference: {e}")
-                
                 # If the model failed during inference, try to re-initialize it for next time
                 # but use fallback for this request
                 initialize_model()
@@ -440,27 +441,34 @@ async def translate_document_endpoint(
     target_lang: str = Form("ar")
 ):
     """Translates text extracted from an uploaded document."""
+    print("[DEBUG] /translate/document endpoint called (Updated Code Check)") # Added log
     try:
         # Extract text directly from the uploaded file
+        print(f"[DEBUG] Processing file: {file.filename}, Source: {source_lang}, Target: {target_lang}")
         extracted_text = await extract_text_from_file(file)
         
         if not extracted_text:
+            print("[DEBUG] No text extracted from document.")
             raise HTTPException(status_code=400, detail="Could not extract any text from the document.")
 
-        # Translate the extracted text
+        # Translate the extracted text using the updated translate_text function
+        print("[DEBUG] Calling translate_text for document content...")
         translated_text = translate_text(extracted_text, source_lang, target_lang)
 
+        print(f"[DEBUG] Document translation successful. Returning result for {file.filename}")
         return JSONResponse(content={
             "original_filename": file.filename,
-            "detected_source_lang": source_lang,
+            "detected_source_lang": source_lang, # Assuming source_lang is detected or provided correctly
             "translated_text": translated_text
         })
 
     except HTTPException as http_exc:
+        # Re-raise HTTPExceptions directly
         raise http_exc
     except Exception as e:
         print(f"Document translation error: {e}")
         traceback.print_exc()
+        # Return a generic error response
         raise HTTPException(status_code=500, detail=f"Document translation error: {str(e)}")
 
 # --- Run the server (for local development) ---

static/script.js

@@ -2,142 +2,119 @@
 window.onload = function() {
     console.log('Window fully loaded, initializing translation app');
     
-    // Get form elements using direct form access instead of getElementById
+    // Get form elements ONCE after load
     const textTranslationForm = document.querySelector('#text-translation-form');
     const docTranslationForm = document.querySelector('#doc-translation-form');
     
+    // Get text form INPUT elements ONCE
+    const textInput = document.getElementById('text-input');
+    const sourceLangText = document.getElementById('source-lang-text');
+    const targetLangText = document.getElementById('target-lang-text');
+    const textLoadingElement = document.getElementById('text-loading');
+    const debugElement = document.getElementById('debug-info');
+    const errorElement = document.getElementById('error-message');
+    const textResultBox = document.getElementById('text-result');
+    const textOutputElement = document.getElementById('text-output');
+
+    // Check if essential text elements were found on load
+    if (!textTranslationForm || !textInput || !sourceLangText || !targetLangText) {
+        console.error('CRITICAL: Essential text form elements not found on window load!', {
+            form: !!textTranslationForm,
+            input: !!textInput,
+            source: !!sourceLangText,
+            target: !!targetLangText
+        });
+        if (errorElement) {
+            errorElement.textContent = 'Error: Could not find essential text translation form elements. Check HTML IDs.';
+            errorElement.style.display = 'block';
+        }
+        // Optionally disable the form if elements are missing
+        if (textTranslationForm) textTranslationForm.style.opacity = '0.5'; 
+        return; // Stop further initialization if critical elements missing
+    }
+    
     // Set up text translation form
-    if (textTranslationForm) {
-        console.log('Text translation form found');
+    console.log('Text translation form and elements found on load');
+    textTranslationForm.addEventListener('submit', function(event) {
+        event.preventDefault();
+        console.log('Text translation form submitted');
         
-        // Use standard form submit event
-        textTranslationForm.addEventListener('submit', function(event) {
-            event.preventDefault();
-            console.log('Text translation form submitted');
-            
-            // Clear previous results and errors
-            document.querySelectorAll('#text-result, #error-message, #debug-info').forEach(el => {
-                if (el) el.style.display = 'none';
-            });
-            
-            // Debugging: Log the form element itself
-            console.log('Form element context (this):', this);
-            
-            // Always select elements from the form context
-            const textInput = this.querySelector('#text-input');
-            // Debugging: Log the result of the querySelector
-            console.log('Result of this.querySelector(\'#text-input\'):', textInput);
-            
-            const sourceLang = this.querySelector('#source-lang-text');
-            console.log('Result of this.querySelector(\'#source-lang-text\'):', sourceLang);
-            
-            const targetLang = this.querySelector('#target-lang-text');
-            console.log('Result of this.querySelector(\'#target-lang-text\'):', targetLang);
-            
-            const loadingElement = document.querySelector('#text-loading');
-            const debugElement = document.querySelector('#debug-info');
-            
-            // Log which elements were found
-            console.log('Elements found:', {
-                textInput: !!textInput,
-                sourceLang: !!sourceLang,
-                targetLang: !!targetLang
-            });
-            
-            // Show debug info
-            if (debugElement) {
-                debugElement.textContent = `Form elements found: 
-                    text-input: ${!!textInput}
-                    source-lang-text: ${!!sourceLang}
-                    target-lang-text: ${!!targetLang}`;
-                debugElement.style.display = 'block';
+        // Hide previous results/errors
+        if (textResultBox) textResultBox.style.display = 'none';
+        if (errorElement) errorElement.style.display = 'none';
+        if (debugElement) debugElement.style.display = 'none';
+        
+        // **Crucial Check:** Verify elements still exist before use
+        if (!textInput || !sourceLangText || !targetLangText) {
+             console.error('ERROR: Text form elements became null before accessing value!');
+             showError('Internal error: Form elements missing unexpectedly.');
+             return;
+        }
+        
+        // Get values
+        const text = textInput.value ? textInput.value.trim() : '';
+        if (!text) {
+            showError('Please enter text to translate');
+            return;
+        }
+        
+        const sourceLangValue = sourceLangText.value;
+        const targetLangValue = targetLangText.value;
+        
+        // Show loading indicator
+        if (textLoadingElement) textLoadingElement.style.display = 'block';
+        
+        // Create payload
+        const payload = {
+            text: text,
+            source_lang: sourceLangValue,
+            target_lang: targetLangValue
+        };
+        
+        console.log('Sending payload:', payload);
+        
+        // Send API request
+        fetch('/translate/text', {
+            method: 'POST',
+            headers: { 'Content-Type': 'application/json' },
+            body: JSON.stringify(payload)
+        })
+        .then(response => {
+            if (!response.ok) throw new Error('Server error: ' + response.status);
+            return response.text(); // Get raw text first
+        })
+        .then(responseText => {
+            console.log('Response received:', responseText);
+            let data;
+            try {
+                data = JSON.parse(responseText);
+            } catch (error) {
+                console.error("Failed to parse JSON:", responseText);
+                throw new Error('Invalid response format from server');
             }
             
-            // Check for missing elements
-            if (!textInput || !sourceLang || !targetLang) {
-                // Debugging: Log which specific elements are missing
-                console.error('Missing elements:', { 
-                    textInput: textInput, 
-                    sourceLang: sourceLang, 
-                    targetLang: targetLang 
-                });
-                showError('Form elements not found. Please check the HTML structure and console logs.');
-                return;
+            if (!data.success || !data.translated_text) {
+                throw new Error(data.error || 'No translation returned or success flag false');
             }
             
-            // Get values
-            const text = textInput.value ? textInput.value.trim() : '';
-            if (!text) {
-                showError('Please enter text to translate');
-                return;
+            // Show result
+            if (textResultBox && textOutputElement) {
+                textOutputElement.textContent = data.translated_text;
+                textResultBox.style.display = 'block';
             }
-            
-            // Get language selections
-            const sourceLangValue = sourceLang.value;
-            const targetLangValue = targetLang.value;
-            
-            // Show loading indicator
-            if (loadingElement) loadingElement.style.display = 'block';
-            
-            // Create payload
-            const payload = {
-                text: text,
-                source_lang: sourceLangValue,
-                target_lang: targetLangValue
-            };
-            
-            console.log('Sending payload:', payload);
-            
-            // Send API request
-            fetch('/translate/text', {
-                method: 'POST',
-                headers: { 'Content-Type': 'application/json' },
-                body: JSON.stringify(payload)
-            })
-            .then(function(response) {
-                if (!response.ok) throw new Error('Server error: ' + response.status);
-                return response.text();
-            })
-            .then(function(responseText) {
-                console.log('Response received:', responseText);
-                
-                // Try to parse JSON
-                let data;
-                try {
-                    data = JSON.parse(responseText);
-                } catch (error) {
-                    throw new Error('Invalid response from server');
-                }
-                
-                // Check for translation
-                if (!data.translated_text) {
-                    throw new Error('No translation returned');
-                }
-                
-                // Show result
-                const resultBox = document.querySelector('#text-result');
-                const outputElement = document.querySelector('#text-output');
-                
-                if (resultBox && outputElement) {
-                    outputElement.textContent = data.translated_text;
-                    resultBox.style.display = 'block';
-                }
-            })
-            .catch(function(error) {
-                showError(error.message || 'Translation failed');
-                console.error('Error:', error);
-            })
-            .finally(function() {
-                if (loadingElement) loadingElement.style.display = 'none';
-            });
+        })
+        .catch(error => {
+            showError(error.message || 'Translation failed');
+            console.error('Error:', error);
+        })
+        .finally(() => {
+            if (textLoadingElement) textLoadingElement.style.display = 'none';
         });
-    } else {
-        console.error('Text translation form not found in the document!');
-    }
+    });
     
     // Document translation handler
     if (docTranslationForm) {
-        console.log('Document translation form found');
+        console.log('Document translation form found on load');
         docTranslationForm.addEventListener('submit', function(event) {
             event.preventDefault();
             console.log('Document translation form submitted');
@@ -201,16 +178,15 @@ window.onload = function() {
             });
         });
     } else {
-        console.error('Document translation form not found in the document!');
+        console.error('Document translation form not found on load!');
     }
     
     // Helper function to show errors
     function showError(message) {
-        const errorDiv = document.querySelector('#error-message');
-        if (errorDiv) {
-            errorDiv.textContent = 'Error: ' + message;
-            errorDiv.style.display = 'block';
+        if (errorElement) {
+            errorElement.textContent = 'Error: ' + message;
+            errorElement.style.display = 'block';
         }
-        console.error('Error:', message);
+        console.error('Error displayed:', message);
     }
 };